-
Notifications
You must be signed in to change notification settings - Fork 333
Timeout for stuck websocket connections #4636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you seen the function withPingPong
from websockets? Perhaps we don't have to implement this.
activityTimeout = 30000000, -- TODO | ||
pongTimeout = 30000000 -- TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending TODOs. Perhaps these value should come from configs and maybe we can write a test then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something went wrong when I last rebased, it seems some commits got lost.
I've seen it, but I can't see how to use it to implement our desired behaviour (i.e. only submit pings after inactivity). |
Hmm, perhaps its ok to just send pings all the time? The point of all this is to kill connections which have inactive clients. |
Sorry about the broken PR. Should be ok to review now. |
Co-authored-by: Akshay Mankar <[email protected]>
This PR adds some cleanup logic for rabbitmq websocket connections that have been inactive for some configurable amount of time.
https://wearezeta.atlassian.net/browse/WPB-17895
Checklist
changelog.d