detached background worker 2nd attempt #4634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
supersven
force-pushed
the
sventennie/detached-background-worker-snd-attempt
branch
from
48e1eae to
dc47117
Compare
Otherwise, left-overs from previous test runs aren't cleaned on time. This is of course a tradeoff with wasting CPU cycles for unnecessary cleanups. However, this is one of the rare parameters to influence the V0/V1/V2 background-workers without patching old versions.
This needs more testing.
Clarify what will happen and why it's okay.
supersven
force-pushed
the
sventennie/detached-background-worker-snd-attempt
branch
from
dc47117 to
bb12248
Compare
Actually, there's a loop that handles the cleanup. Because the cleanup logic depends on existing queues, there's not much we can do here.
supersven
force-pushed
the
sventennie/detached-background-worker-snd-attempt
branch
from
e4e400a to
9c38cb4
Compare
fisx
approved these changes
Jul 24, 2025
supersven
force-pushed
the
sventennie/detached-background-worker-snd-attempt
branch
from
9c38cb4 to
574d70d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually, there isn't much we can do when a queue is externally deleted:
V0andV1) cannot be changed anymore.To heal the symptoms of detached consumers, I've decreased the cleanup interval for local integration test runs to one Second. That should be a good tradeoff between the time to re-execute tests and not making to many bogus requests to RabbitMQ.
I've also added a test to ensure that reestablishing the consumer works.
Ticket: https://wearezeta.atlassian.net/browse/WPB-17247
Checklist
changelog.d