Skip to content

WPB-17737 send an event to rabbit mq cells bus when the cells feature flag is enabled on a team #4614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 16, 2025
Merged

WPB-17737 send an event to rabbit mq cells bus when the cells feature flag is enabled on a team #4614

merged 4 commits into from
Jun 16, 2025

Conversation

battermann
Copy link
Contributor

@battermann battermann commented Jun 13, 2025 •
edited
Loading

https://wearezeta.atlassian.net/browse/WPB-17737

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@battermann battermann marked this pull request as ready for review June 13, 2025 13:45
@battermann battermann requested review from a team as code owners June 13, 2025 13:45
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jun 13, 2025
pcapriotti
pcapriotti reviewed Jun 13, 2025
View reviewed changes
Copy link
Contributor

@pcapriotti pcapriotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced that we need an ad-hoc mechanism for this event here. Couldn't we extend the normal FeatureConfig.Event logic to optionally send events to cells just like we have done for conversation events?

@battermann battermann requested a review from pcapriotti June 13, 2025 14:07
@battermann battermann merged commit 901a315 into develop Jun 16, 2025
8 checks passed
@battermann battermann deleted the WPB-17737-send-an-event-to-rabbit-mq-cells-bus-when-the-cells-feature-flag-is-enabled-on-a-team branch June 16, 2025 08:27
@zebot zebot mentioned this pull request Jun 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcapriotti pcapriotti pcapriotti approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@battermann @pcapriotti @zebot