Skip to content

[WPB-1753] list user groups #4607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 112 commits into from
Aug 1, 2025
Merged

[WPB-1753] list user groups #4607

merged 112 commits into from
Aug 1, 2025

Conversation

fisx
Copy link
Contributor

@fisx fisx commented Jun 5, 2025 •
edited by battermann
Loading

https://wearezeta.atlassian.net/browse/WPB-17534

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@fisx fisx marked this pull request as draft June 5, 2025 10:01
@fisx fisx changed the title WPB-17534-list-user-groups [WPB-1753] list user groups Jun 5, 2025
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jun 5, 2025
fisx
fisx commented Jun 6, 2025
View reviewed changes
@fisx fisx force-pushed the WPB-17534-list-user-groups branch 7 times, most recently from 66a6d46 to 4fc0d70 Compare June 13, 2025 08:54
@fisx fisx force-pushed the WPB-17534-list-user-groups branch 4 times, most recently from 3f64062 to 26d3c10 Compare June 30, 2025 20:19
@fisx fisx force-pushed the WPB-17534-list-user-groups branch 3 times, most recently from b8c0273 to 90579ad Compare July 11, 2025 13:37
@fisx fisx marked this pull request as ready for review July 14, 2025 09:01
@fisx fisx requested review from a team as code owners July 14, 2025 09:01
@fisx fisx mentioned this pull request Jul 14, 2025
Closed
2 tasks
@fisx fisx changed the title [WPB-1753] list user groups [no ci] [WPB-1753] list user groups Jul 15, 2025
@fisx fisx force-pushed the WPB-17534-list-user-groups branch from 8b111b9 to 009415e Compare July 15, 2025 10:24
@fisx fisx removed the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jul 15, 2025
@fisx fisx force-pushed the WPB-17534-list-user-groups branch from 009415e to 5ea93a7 Compare July 16, 2025 06:53
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jul 16, 2025
@fisx fisx mentioned this pull request Jul 16, 2025
Merged
2 tasks
@fisx fisx force-pushed the WPB-17534-list-user-groups branch from 5ea93a7 to c0bbee1 Compare July 16, 2025 07:26
fisx and others added 25 commits July 31, 2025 16:38
@fisx @battermann
Enforce valid pagination states in ToSchema, Arbitrary.
427db83
@fisx @battermann
Clean up postgres connection pool in unit tests.
116fad9
@fisx @battermann
Haddocks.
c56b85b
@fisx @battermann
Add missing integration tests.
697306f
@fisx @battermann
make sanitize-pr
075c33a
@battermann
fix golden test
8c5e0b5
@battermann
refactor wire-api
c985d3a
@battermann
wip
7f6f161
@akshaymankar @battermann
more wip
e169c5c
@akshaymankar @battermann
Tests succeed
e81020a
@akshaymankar @battermann
Delete unused unsafe function
bb4ef43
@akshaymankar @battermann
Delete unused error
6d6ee17
@akshaymankar @battermann
Move servant code to the route module
e44f71c
@akshaymankar @battermann
Delete tests for postgresql queries
f2de6ab
@akshaymankar @battermann
Delete unused unsafe function
30f6beb
@akshaymankar @battermann
Unique name for UserGroupMeta in swagger
d2d25fc
@akshaymankar @battermann
Delete stale haddock
2ea5eff
@akshaymankar @battermann
Rename toText to clearer function names
8b2fbc9 
Also make it a normal function instead of `HasField`

So:

sortBy.toText -> sortColumnName sortBy
sortOrder.toText -> sortOrderClause sortOrder

Also:
sortOreder.op -> sortOrderOperator sortOrder
@akshaymankar @battermann
Docs for query params
13e45ef
@battermann
clean up user group postrgres interpreter
a244ce6
@battermann
remove todo, it says above why
07c0d42
@battermann
renaming
8f31795
@battermann
remove todo
7ea6e9e
@battermann
test all combinations of query parameters
a174a94
@battermann
fix errors introduced by rebasing
bd44919
@battermann battermann force-pushed the WPB-17534-list-user-groups branch from 452f71d to bd44919 Compare July 31, 2025 16:57
@battermann battermann merged commit 542abf5 into develop Aug 1, 2025
8 checks passed
@battermann battermann deleted the WPB-17534-list-user-groups branch August 1, 2025 09:30
@zebot zebot mentioned this pull request Aug 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanwire stefanwire stefanwire approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fisx @stefanwire @battermann @zebot @akshaymankar