Skip to content

WPB-16887 Allow Team Admin to Change a Channel Name #4584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 11, 2025
Merged

WPB-16887 Allow Team Admin to Change a Channel Name #4584

merged 2 commits into from
Jun 11, 2025

Conversation

battermann
Copy link
Contributor

@battermann battermann commented May 19, 2025 •
edited
Loading

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@battermann battermann marked this pull request as ready for review May 19, 2025 09:27
@battermann battermann requested review from a team as code owners May 19, 2025 09:27
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label May 19, 2025
@battermann battermann marked this pull request as draft May 21, 2025 10:30
@battermann battermann force-pushed the WPB-16876-allow-team-admin-to-add-users-and-user-groups-to-a-channel-they-are-not-in branch from 9f02a25 to ba9d7f0 Compare May 21, 2025 10:31
@battermann battermann force-pushed the WPB-16887-allow-team-admin-to-change-a-channels-name branch from 6ea46bb to 52b784e Compare May 21, 2025 10:31
@battermann battermann force-pushed the WPB-16876-allow-team-admin-to-add-users-and-user-groups-to-a-channel-they-are-not-in branch from ba9d7f0 to b6a9003 Compare May 21, 2025 10:42
@battermann battermann force-pushed the WPB-16887-allow-team-admin-to-change-a-channels-name branch from 52b784e to bf1427a Compare May 21, 2025 10:44
@battermann battermann force-pushed the WPB-16876-allow-team-admin-to-add-users-and-user-groups-to-a-channel-they-are-not-in branch from b6a9003 to 046ea1a Compare June 5, 2025 12:03
@battermann battermann force-pushed the WPB-16887-allow-team-admin-to-change-a-channels-name branch from bf1427a to 763a215 Compare June 6, 2025 08:07
Base automatically changed from WPB-16876-allow-team-admin-to-add-users-and-user-groups-to-a-channel-they-are-not-in to develop June 11, 2025 09:26
@battermann battermann force-pushed the WPB-16887-allow-team-admin-to-change-a-channels-name branch from 763a215 to 536e41f Compare June 11, 2025 10:22
@battermann battermann marked this pull request as ready for review June 11, 2025 10:23
@battermann battermann force-pushed the WPB-16887-allow-team-admin-to-change-a-channels-name branch from 536e41f to d53c8fb Compare June 11, 2025 10:28
@supersven supersven self-assigned this Jun 11, 2025
supersven
supersven approved these changes Jun 11, 2025
View reviewed changes
Copy link
Contributor

@supersven supersven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I really like your style of always providing a counter example in test assertions 👍

@battermann battermann merged commit 851b1fc into develop Jun 11, 2025
8 checks passed
@battermann battermann deleted the WPB-16887-allow-team-admin-to-change-a-channels-name branch June 11, 2025 11:49
@zebot zebot mentioned this pull request Jun 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supersven supersven supersven approved these changes

Assignees

@supersven supersven

Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@battermann @supersven @zebot