Skip to content

Fix docker-compose redis replication #4566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 12, 2025
Merged

Fix docker-compose redis replication #4566

merged 3 commits into from
May 12, 2025

Conversation

supersven
Copy link
Contributor

@supersven supersven commented May 6, 2025 •
edited
Loading

I've taken some care to put explanations into the commit messages. So, it might make sense to review this PR commit-by-commit.

  • We allow only TLS connections to the Redis nodes. Thus the replication has to use TLS as well (by default it doesn't.)
  • Add missing newlines. These files are interpreted as "POSIX text files". And, thus should adhere to their standards.

Ticket: https://wearezeta.atlassian.net/browse/WPB-17247

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

supersven added 2 commits May 6, 2025 16:40
@supersven
Fix Redis replication (docker-compose env)
5356d4f 
We allow only TLS connections to the Redis nodes. Thus we replication
has to use TLS as well (by default it doesn't.)

See
https://redis.io/docs/latest/operate/oss_and_stack/management/security/encryption/#replication
@supersven
Add missing newlines
a84829f 
These files are interpreted as "POSIX text files". And, thus should
adhere to their standards.

See
https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206
@supersven supersven requested a review from a team as a code owner May 6, 2025 14:44
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label May 6, 2025
@supersven supersven requested review from a team as code owners May 6, 2025 14:47
@supersven
Copy link
Contributor Author

gundeck and integration integration-tests are green (others I haven't checked.)

@supersven supersven merged commit 166c215 into develop May 12, 2025
3 checks passed
@supersven supersven deleted the sventennie/fix-docker-compose-redis-replication branch May 12, 2025 09:28
This was referenced May 12, 2025
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshaymankar akshaymankar akshaymankar approved these changes

@battermann battermann battermann approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@supersven @akshaymankar @battermann @zebot