Skip to content

[WPB-16420] Move saml2-web-sso repo to /libs/ #4492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Mar 12, 2025
Merged

[WPB-16420] Move saml2-web-sso repo to /libs/ #4492

merged 21 commits into from
Mar 12, 2025

Conversation

fisx
Copy link
Contributor

@fisx fisx commented Mar 10, 2025 •
edited by supersven
Loading

https://wearezeta.atlassian.net/browse/WPB-16420

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@fisx fisx changed the title Move saml2-web-sso repo to /libs/ [WPB-16420] Move saml2-web-sso repo to /libs/ Mar 10, 2025
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Mar 10, 2025
@fisx fisx force-pushed the WPB-16420-swallow-saml2-web-sso-repo branch from 8e2b6ee to 0142bea Compare March 10, 2025 20:13
@fisx fisx force-pushed the WPB-16420-swallow-saml2-web-sso-repo branch from 0142bea to bf0a9d5 Compare March 10, 2025 20:25
@fisx fisx requested a review from supersven March 10, 2025 20:25
supersven
supersven reviewed Mar 11, 2025
View reviewed changes
supersven and others added 8 commits March 11, 2025 09:25
@supersven
Run saml2-web-sso tests
b2a6b50 
Tests can be executed now, so we should.
@supersven
No constraint on the saml2-web-sso version
e4b41a8 
We simply want to take what's in this current checkout.
@supersven
Delete .gitignore
3335c92 
Let's start with what we already ignored at top-level. If we ever need
special rules here, we can simply create a new .gitignore file.
@supersven
Add changelog
936e42f
@supersven
Reformat
e5dc2c1
@supersven
Fix Hlint issues that cannot be auto-fixed
2ad998d
@fisx
More prominent warnings when hlint-inplace fails.
572f9c2
@fisx
Merge remote-tracking branch 'refs/remotes/origin/WPB-16420-swallow-s…
f1f18c9 
…aml2-web-sso-repo' into WPB-16420-swallow-saml2-web-sso-repo
@supersven supersven marked this pull request as ready for review March 11, 2025 09:57
@supersven supersven requested review from a team as code owners March 11, 2025 09:57
@supersven supersven force-pushed the WPB-16420-swallow-saml2-web-sso-repo branch from 3c080da to aaa656f Compare March 11, 2025 13:51
@supersven
Run tests without SAML2_WEB_SSO_ROOT env var
b5e48ef 
Having to define this var just makes things complicated.

Fixup
@supersven supersven force-pushed the WPB-16420-swallow-saml2-web-sso-repo branch from fc54d31 to 9bba6fa Compare March 11, 2025 14:26
@fisx fisx merged commit 9aa8df3 into develop Mar 12, 2025
10 checks passed
@fisx fisx deleted the WPB-16420-swallow-saml2-web-sso-repo branch March 12, 2025 08:48
@zebot zebot mentioned this pull request Apr 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supersven supersven supersven approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fisx @supersven @zebot