Skip to content

Cleanup old team feature storage #4470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 11, 2025
Merged

Cleanup old team feature storage #4470

merged 5 commits into from
Mar 11, 2025

Conversation

pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Feb 25, 2025

This PR removes support for legacy team feature storage, and forces the use of the new dynamic feature table introduced in #4459.

Since #4459 and #4472 contain the data migration needed to fully migrate to the new storage, it is important that this PR not be merged before both of those PRs are included in a release.

https://wearezeta.atlassian.net/browse/WPB-16238

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Feb 25, 2025
Base automatically changed from simplify-feature-table-2 to develop February 25, 2025 16:11
@pcapriotti pcapriotti changed the title Cleanup old team feature storage [DO-NOT-MERGE] Cleanup old team feature storage Feb 28, 2025
@pcapriotti pcapriotti force-pushed the cleanup-old-features branch 2 times, most recently from a09d8d1 to 1f6719e Compare March 5, 2025 14:39
@pcapriotti pcapriotti force-pushed the cleanup-old-features branch from 1f6719e to 795418c Compare March 6, 2025 08:33
@pcapriotti pcapriotti changed the title [DO-NOT-MERGE] Cleanup old team feature storage Cleanup old team feature storage Mar 6, 2025
@pcapriotti pcapriotti marked this pull request as ready for review March 6, 2025 12:32
@pcapriotti pcapriotti requested review from a team as code owners March 6, 2025 12:32
@battermann
Copy link
Contributor

So we are keeping the DB schema for now? I guess that is fine.

@pcapriotti
Copy link
Contributor Author

So we are keeping the DB schema for now? I guess that is fine.

You mean the old table itself? Yeah, we have to keep it to prevent issues during deployment. We can get rid of it in one of the next releases.

@battermann battermann merged commit 28640b6 into develop Mar 11, 2025
10 checks passed
@battermann battermann deleted the cleanup-old-features branch March 11, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants