Skip to content

Conversation

mohitrajain
Copy link
Contributor

@mohitrajain mohitrajain commented Feb 19, 2025

Before merging it, we need to approve merge this PR:
#4474

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@mohitrajain mohitrajain requested review from a team as code owners February 19, 2025 16:32
@mohitrajain mohitrajain changed the title Clean wire-server/docs and migrate to wire-docs repository Clean wire-server/docs and migrate to wire-docs repository WPB-16191 Feb 24, 2025
…nfig-options.md which isn't present in wire-docs
@stefanwire
Copy link
Contributor

stefanwire commented Mar 6, 2025

Are you deleting files which are still referenced by remaining files? For instance, /docs/src/understand/single-sign-on/understand/token-step-01.png.

@mohitrajain mohitrajain mentioned this pull request Mar 7, 2025
2 tasks
@mohitrajain
Copy link
Contributor Author

@stefanwire Thanks for pointing it out, all the documents which are new and have dependencies on other documents will stay here. I will make the appropriate change for it and find out if other pages/assets are missing.

@mohitrajain
Copy link
Contributor Author

@stefanwire I have pushed all the static images referenced by recent pages in wire-server.

CURRENT_BRANCH="${GITHUB_REF#refs/heads/}"
fi

sed -i "s|url = https://github.com/mohitrajain/wire-server.git|url = ${CURRENT_REPO_URL}|g" .gitmodules
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The submodule should be pointing to wireapp/wireserver and develop branch once it has been pushed. For now, it is pointing to the temporary repo and branch to test the pipeline.

…nfig-options.md which isn't present in wire-docs
…nfig-options.md which isn't present in wire-docs
@smatting
Copy link
Contributor

Fine to merge without ci, because only docs are changed

@smatting smatting merged commit 23cfc09 into wireapp:develop Mar 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants