Skip to content

WPB-14307 Update Authentication Flow #4422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Jan 30, 2025
Merged

WPB-14307 Update Authentication Flow #4422

merged 32 commits into from
Jan 30, 2025

Conversation

battermann
Copy link
Contributor

@battermann battermann commented Jan 27, 2025 •
edited
Loading

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@echoes-hq echoes-hq bot added the echoes/initiative: scale Enterprise Readiness Initiatives label Jan 27, 2025
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jan 27, 2025
@battermann battermann marked this pull request as ready for review January 27, 2025 15:33
fisx
fisx approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@fisx fisx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we probably should fix mk-changelog.sh. (but can you even reproduce it?)

libs/wire-subsystems/src/Wire/EnterpriseLoginSubsystem.hs
CreateDomainVerificationChallenge ::
Domain ->
EnterpriseLoginSubsystem m DomainVerificationChallenge
VerifyChallenge ::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
VerifyChallenge ::
VerifyChallengeResponse ::

?

@pcapriotti pcapriotti force-pushed the WPB-14307-new-auth branch 2 times, most recently from 888e9ab to cfcce5c Compare January 29, 2025 09:11
battermann and others added 23 commits January 30, 2025 11:40
@battermann @pcapriotti
updated db schema
3cae1a0
@battermann @pcapriotti
handler for creating a new challenge
4ba9572
@pcapriotti
Finish implementing new challenge handler
7d29aaa
@pcapriotti
Add stub of verify challenge effect
5a88a7f
@battermann @pcapriotti
store auth token after verification
fdd1cee
@battermann @pcapriotti
add new endpoints to brig and wire up handlers
767cbaf
@battermann @pcapriotti
test domain verification and fix queries, renaming
26deae7
@battermann @pcapriotti
authorized team column added to domain registration table
11e9f85
@battermann @pcapriotti
renamed auth token to ownership token
8b76eab
@battermann @pcapriotti
authorize team subsystem handler
e753e4e
@pcapriotti
Add authorizeTeam handler and route
2afa71a
@pcapriotti
Perform ownership check in updateDomainRedirect
a3c1f84
@pcapriotti
Refactor DomainRegistration and introduce DomainRegistrationResponse
38fd1ac
@pcapriotti
Rename golden test cases
2a18d9c
@pcapriotti
Refactor fromStore/toStore for DomainRegistration
451815d
@battermann @pcapriotti
added authorization to update team handler
1b5b92c
@battermann @pcapriotti
clean up errors
ea36840
@battermann @pcapriotti
fix enterprise login tests
3df10fd
@pcapriotti
Fix error logging in lookup
ae5bd46
@pcapriotti
updated the test for new auth flow and fixed bugs
8f1b3b6
@pcapriotti
Test overwriting ownership token
18c1757
@pcapriotti
Add TTL to challenges
9121d43
@battermann @pcapriotti
update config map
b5c1751
battermann and others added 7 commits January 30, 2025 11:42
@battermann @pcapriotti
yaml formatting
534fc06
@battermann @pcapriotti
test challenge api ttl
78a014b
@battermann @pcapriotti
changelog
37d591c
@pcapriotti
Improve changelog generation
547318c 
Look for existing PR number anywhere in the input, in order to decide
whether to add a new PR number at the end of the entry.
@pcapriotti
Reformat CHANGELOG entry
ad899fc
@pcapriotti
Lint
a3c07af
@battermann @pcapriotti
update changelog
e47dd6a
@battermann battermann merged commit 5483a77 into develop Jan 30, 2025
11 checks passed
@battermann battermann deleted the WPB-14307-new-auth branch January 30, 2025 13:49
@zebot zebot mentioned this pull request Feb 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcapriotti pcapriotti pcapriotti left review comments

@fisx fisx fisx approved these changes

Assignees
No one assigned
Labels
echoes/initiative: scale Enterprise Readiness Initiatives ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@battermann @pcapriotti @fisx @zebot