Stabilize index migration tests #4413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Knowing the index name(s) to handle, simplifies debugging the ElasticSearch test proxy.
zebot
added
the
ok-to-test
The additional index doesn't have to reside on the same ElasticSearch instance. In fact, in some tests we simulate (with proxies) that it doesn't. These tests were flaky due to the second index not being refreshed.
supersven
force-pushed
the
sventennie/deflake-index-migration-tests
branch
from
ef177e5 to
9ae50c4
Compare
supersven
changed the title
fisx
approved these changes
Jan 17, 2025
1 task
echoes-hq
bot
added
the
echoes: technical-roadmap/throughput
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional indices were not correctly refreshed in testMigrationToNewIndex due to a proxy masking them (forbidding to write access to the additional index with the default one's proxy URL.) Thus, it was a bit of luck if all index writes could be read, which led to flaky tests.
This PR lets
/i/index/refreshsync default and additional indices with their dedicated URL.Tickets:
N.B. yes, it is a bit weird to request merging with a failing pipeline. But, index migration tests seem to be stable now.
Checklist
changelog.d