Skip to content

[WPB-2565] Extend a team conversation test with event assertions #3731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mdimjasevic wants to merge 2 commits into from
Closed

[WPB-2565] Extend a team conversation test with event assertions #3731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07505a7
Extend a team conversation test event assertions
Nov 21, 2023
663aec8
Update a changelog
Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion changelog.d/2-features/WPB-2565-member-updates
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Events for a member update, join and leave are not sent to everyone in the team any longer. Only team admins get them.
Events for a member update, join and leave are not sent to everyone in the team any longer. Only team admins get them. (#3703, #3731)
33 changes: 32 additions & 1 deletion services/galley/test/integration/API.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1567,11 +1567,13 @@ postConvertTeamConv = do
-- Create a team conversation with team-alice, team-bob, activated-eve
-- Non-activated mallory can join
(alice, tid) <- createBindingTeam
let qalice = Qualified alice localDomain
bob <- view Teams.userId <$> addUserToTeam alice tid
let qalice = Qualified alice localDomain
qbob = Qualified bob localDomain
assertTeamUpdate "team member (bob) join" tid 2 [alice]
refreshIndex
dave <- view Teams.userId <$> addUserToTeam alice tid
let qdave = Qualified dave localDomain
assertTeamUpdate "team member (dave) join" tid 3 [alice]
refreshIndex
(eve, qeve) <- randomUserTuple
Expand Down Expand Up @@ -1612,6 +1614,35 @@ postConvertTeamConv = do
postJoinCodeConv mallory j !!! const 403 === statusCode
-- team members (dave) can still join
postJoinCodeConv dave j !!! const 200 === statusCode
void . liftIO $
WS.assertMatchN (5 # Second) [wsA, wsB] $
wsAssertMemberJoinWithRole qconv qdave [qdave] roleNameWireMember

do
let teamAccessNew =
ConversationAccessData
(Set.fromList [InviteAccess, CodeAccess])
(Set.fromList [TeamMemberAccessRole, NonTeamMemberAccessRole])
putQualifiedAccessUpdate alice qconv teamAccessNew !!! const 200 === statusCode
void . liftIO $
WS.assertMatchN (5 # Second) [wsA, wsB] $
wsAssertConvAccessUpdate qconv qalice teamAccessNew

postJoinCodeConv eve j !!! const 200 === statusCode
void . liftIO $
WS.assertMatchN (5 # Second) [wsA, wsB] $
wsAssertMemberJoinWithRole qconv qeve [qeve] roleNameWireMember

galley <- viewGalley
deleteTeamMember galley tid alice dave
-- Alice gets a team event as a team admin
checkTeamMemberLeave tid dave wsA
liftIO $ do
-- Alice gets no conversation event
WS.assertNoEvent (1 # Second) [wsA]
-- Bob and Eve get a conversation event
WS.assertMatchN_ (5 # Second) [wsB, wsE] $
wsAssertMemberLeave qconv qdave (pure qdave) EdReasonDeleted

testTeamMemberCantJoinViaGuestLinkIfAccessRoleRemoved :: TestM ()
testTeamMemberCantJoinViaGuestLinkIfAccessRoleRemoved = do
Expand Down