-
Notifications
You must be signed in to change notification settings - Fork 333
Fix SCIM role update #3488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SCIM role update #3488
Conversation
More specifically: if role is not set ([], null, or field missing), do not change role to default.
a few more spar tests are failing, but i think that's because the tests need fixing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -1780,13 +1780,14 @@ testUpdateUserRole = do | |||
let galley = env ^. teGalley | |||
(owner, tid) <- call $ createUserWithTeam brig galley | |||
tok <- registerScimToken tid Nothing | |||
let mTargetRoles = Nothing : map Just [minBound ..] | |||
let mRoles = Nothing : map Just [minBound @Role ..] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this type annotation is not needed, is it a left over or is it meant for documenting the code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
both! :)
https://wearezeta.atlassian.net/browse/WPB-2959
reviewer: please read commit by commit.
without the fix, but with the test:
with both:
Checklist
changelog.d