[WPB-3633] client receives conversation deleted conversation events after federation delete event #3485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
battermann
changed the title
don't send event on remote conv delete test that 1:1 conv do not trigger event changelog
battermann
force-pushed
the
WPB-3633-client-receives-conversation-deleted-conversation-events-after-federation-delete-event
branch
from
1a51a6d to
d61ff76
Compare
zebot
added
the
ok-to-test
fisx
approved these changes
Aug 8, 2023
| -- call to brig. This is so we can ensure that domains are correctly cleaned up if a service | ||
| -- falls over for whatever reason. | ||
| deleteFederationRemoteGalley :: Domain -> ExceptT Brig.API.Error.Error (AppT r) () | ||
| deleteFederationRemoteGalley dom = do | ||
| lift . wrapClient . Data.deleteRemoteConnectionsDomain $ dom | ||
| assertNoDomainsFromConfigFiles dom |
There was a problem hiding this comment.
the reason for this line is that if you delete a remote that's also present in the config file, it will fail silently (signal success), as read is always the union of cassandra and yaml, and yaml can't be changed here. there is a comment about this somewhere in this CRUD family.
why did you remove it?
There was a problem hiding this comment.
Yes, but it is in the wrong place. At this point, the federation domain has already been deleted, and we are now cleaning up the local state. There is no need to check this again here.
| for_ (Map.toList remoteConvs) $ \(cnv, lUsers) -> do | ||
| -- All errors, either exceptions or Either e, get thrown into IO | ||
| mapError @NoChanges (const (InternalErrorWithDescription "No Changes: Could not remove a local member from a remote conversation.")) $ do | ||
| E.deleteMembersInRemoteConversation (toRemoteUnsafe dom cnv) (N.toList lUsers) |
There was a problem hiding this comment.
this is certainly more to the point! :)
battermann
deleted the
WPB-3633-client-receives-conversation-deleted-conversation-events-after-federation-delete-event
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-3633
Checklist
changelog.d