Skip to content

Do not accept federation traffic from not-federating backends. #3484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2023
Merged

Do not accept federation traffic from not-federating backends. #3484

merged 1 commit into from
Aug 8, 2023

Conversation

fisx
Copy link
Contributor

@fisx fisx commented Aug 8, 2023 •
edited
Loading

https://wearezeta.atlassian.net/browse/WPB-3665

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@fisx fisx requested a review from elland August 8, 2023 09:17
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Aug 8, 2023
elland
elland approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@elland elland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just wondering whether we could write a test for it.

@fisx
Copy link
Contributor Author

fisx commented Aug 8, 2023

LGTM, just wondering whether we could write a test for it.

I'd like to leave that to QA. It's a bit tricky to write that test, and since QA found it (in a play test), I don't think it's necessary.

@fisx fisx merged commit 17bb991 into develop Aug 8, 2023
@fisx fisx deleted the WPB-3665-reject-msgs-from-defederated-backends branch August 8, 2023 14:09
@zebot zebot mentioned this pull request Aug 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@elland elland elland approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fisx @elland @zebot