Skip to content

nit-picks #3388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 3, 2023
Merged

nit-picks #3388

merged 7 commits into from
Jul 3, 2023

Conversation

fisx
Copy link
Contributor

@fisx fisx commented Jul 3, 2023 •
edited
Loading

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

fisx
fisx commented Jul 3, 2023
View reviewed changes
@fisx fisx requested a review from supersven July 3, 2023 10:55
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jul 3, 2023
supersven
supersven reviewed Jul 3, 2023
View reviewed changes
supersven
supersven reviewed Jul 3, 2023
View reviewed changes
supersven
supersven reviewed Jul 3, 2023
View reviewed changes
supersven
supersven approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@supersven supersven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. Please feel free to add or ignore my suggestions as I don't feel strongly about them.

@fisx fisx merged commit 625ecbf into develop Jul 3, 2023
@fisx fisx deleted the tweak-docs-07-03 branch July 3, 2023 18:59
@zebot zebot mentioned this pull request Aug 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supersven supersven supersven approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fisx @supersven @zebot