[WPB-1085] Two-event member adding process during conversation creation #3359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Conversation creation at this point was able to fail only because remotes were unreachable. As of recently this is handled gracefully: no more throwing in IO, but rather reporting to the creator that some remote users could not be added
zebot
added
the
ok-to-test
2 tasks
mdimjasevic
changed the title
8 tasks
fisx
reviewed
Jun 20, 2023
fisx
reviewed
Jun 26, 2023
| allRemoteMembersQualified = remoteMemberQualify <$> allRemoteMembers | ||
| allRemoteBuckets :: [Remote [RemoteMember]] = bucketRemote allRemoteMembersQualified | ||
| rc = toConversationCreated now c | ||
| failedToNotify <- fmap (foldMap (either (sequenceA . fst) mempty)) $ |
There was a problem hiding this comment.
this looks weird.
the type of the second argument of this fmap is [Either (Remote [RemoteMember], FederationError) (Remote ())].
- shouldn't we keep the buckets with the different remotes, rather than filtering out again below in line 786?
- why does the
FederationErrorhave to be the same value for all remote members? shouldn't it be allowed to differ between members?
There was a problem hiding this comment.
The comment is referring to old code so I'm not sure my reply will address your concerns, but here's an attempt:
- Regarding keeping them in buckets, there are a few variations of the same data, but in different types, each suitable for a slightly different need. We do have buckets around too.
- The same
FederationErrorquestion is, I believe, addressed by the observation I made yesterday during the call: there's no incremental update from a remote backend on the progress of processing member updates, so either all of members are added successfully or there is a failure, e.g., aFederationErroris returned, in which case none of the remote backend's users are considered to be conversation members.
…-conversation-create
…-conversation-create
mdimjasevic
commented
Jul 4, 2023
- It is not actually used in the PR, hence removed
|
@fisx and @battermann , I've merged the latest Let me know if you have any further feedback, remarks, or questions. |
Co-authored-by: Leif Battermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a carved out part of #3324 that relates to conversation creation only.
When a Proteus conversation is created and remote members are added to it as part of the request to
POST /conversations, remote clients now get two events: aconversation.createevent as before with a subset of other members, and also aconversation.member-joinevent once the list of all remote members is confirmed. Local users get only theconversation.createevent as before with the full list of members.For details see https://wearezeta.atlassian.net/wiki/spaces/CORE/pages/751435862/Offline+backend+handling+-+analysis+of+creating+a+conversation#Events-for-joining-clients.
Tracked by https://wearezeta.atlassian.net/browse/WPB-1085.
Checklist
changelog.d