Skip to content

Servantify brig internal api: misc #3339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 9, 2023
Merged

Servantify brig internal api: misc #3339

merged 7 commits into from
Jun 9, 2023

Conversation

fisx
Copy link
Contributor

@fisx fisx commented Jun 5, 2023 •
edited
Loading

https://wearezeta.atlassian.net/browse/SQSERVICES-1089

(1089 has been done already; instead of checking for closable tickets, i'll just go and find migratable internal end-points in brig now.)

To be reviewed best commit-by-commit

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jun 5, 2023
@fisx fisx force-pushed the SQSERVICES-1089 branch 2 times, most recently from cdc43ec to c1143f2 Compare June 5, 2023 16:09
@fisx fisx marked this pull request as ready for review June 5, 2023 17:30
Base automatically changed from SQSERVICES-1088 to develop June 6, 2023 07:59
@fisx fisx force-pushed the SQSERVICES-1089 branch from 1338359 to 60dfa96 Compare June 7, 2023 10:17
@fisx
Copy link
Contributor Author

fisx commented Jun 7, 2023 •
edited
Loading

a841490 will be needed for moving more end-points from wai-routing to servant, but it's intended to be independently valid.

@fisx fisx force-pushed the SQSERVICES-1089 branch 2 times, most recently from 781dd9f to 762ca19 Compare June 7, 2023 13:03
@fisx fisx added not-ok-to-test Not approved for running tests in CI, this label is ignored if ok-to-test also exists on a PR and removed ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist labels Jun 7, 2023
@fisx fisx force-pushed the SQSERVICES-1089 branch from 762ca19 to a841490 Compare June 7, 2023 15:12
@fisx fisx added ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist and removed not-ok-to-test Not approved for running tests in CI, this label is ignored if ok-to-test also exists on a PR labels Jun 8, 2023
@fisx fisx force-pushed the SQSERVICES-1089 branch from 7799e1a to 97ffe12 Compare June 8, 2023 12:19
@fisx fisx requested a review from battermann June 8, 2023 15:46
battermann
battermann approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@battermann battermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fisx fisx merged commit cb2cb0a into develop Jun 9, 2023
@fisx fisx deleted the SQSERVICES-1089 branch June 9, 2023 13:06
@smatting smatting mentioned this pull request Jun 19, 2023
Merged
supersven pushed a commit that referenced this pull request Jul 5, 2023
@fisx @supersven
Servantify brig internal api: misc (#3339)
d960962 
* Servantify brig internal api: /i/status

* Servantify brig internal api: put /i/self/email

* Servantify brig internal api: delete /i/user/:uid

* Refactor: move `AccountStatus` and friends to wire-api.

* Servantify brig internal api: put,get /i/user/:uid/status
@zebot zebot mentioned this pull request Aug 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@battermann battermann battermann approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fisx @battermann @zebot