Export Data.String.Conversions.cs from Imports #3320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
zebot
added
the
ok-to-test
elland
approved these changes
May 30, 2023
supersven
pushed a commit
that referenced
this pull request
Jul 5, 2023
* Export cs from Imports * Remove stupid type aliases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes:
s/SBS/ByteString/gs/LBS/LByteString/gs/ST/Text/gs/LT/LText/gimport Data.String.Conversions.*(at least in most places...)csfromImportsimports in a few places to avoid name shadowingcs is technically not always safe, because it can crash when trying to convert a bytestring elf binary into text. but first of all, we already use cs everywhere, and furthermore, unpack does exactly the same thing, so we wouldn't be any safer without cs. (i think.)
Checklist
changelog.d