Introduce SearchContacts permission. #3252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
smatting
approved these changes
Apr 27, 2023
| @@ -92,6 +93,7 @@ search :: | |||
| Maybe (Range 1 500 Int32) -> | |||
| (Handler r) (Public.SearchResult Public.Contact) | |||
| search searcherId searchTerm maybeDomain maybeMaxResults = do | |||
| ensurePermissionsOrPersonalUser searcherId [SearchContacts] | |||
There was a problem hiding this comment.
This could be moved into searchLocally, which already looks up the team id. Federated searching has its own policies, maybe this check isn't relevant there.
There was a problem hiding this comment.
i agree that's a possible optimization, but i think we should also disallow remote searches for ephemeral users. i'll leave a comment in the code, ok?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/FS-1880
integration test is under way elsewhere for technical reasons.
Checklist
changelog.d