Skip to content

Remove unused deps #3242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 24, 2023
Merged

Remove unused deps #3242

merged 3 commits into from
Apr 24, 2023

Conversation

fisx
Copy link
Contributor

@fisx fisx commented Apr 21, 2023 •
edited
Loading

Add -Wunused-packages everywhere, fix warnings.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@fisx
Copy link
Contributor Author

fisx commented Apr 21, 2023

(i don't think this warrants adding a changelog entry.)

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Apr 21, 2023
elland
elland reviewed Apr 24, 2023
View reviewed changes
@fisx
Copy link
Contributor Author

fisx commented Apr 24, 2023

with -Wunused-packages i get this much info about things to remove:

Building test suite 'spec' for polysemy-wire-zoo-0.1.0..

<no location info>: warning: [-Wunused-packages]
    The following packages were specified via -package or -package-id flags,
    but were not needed for compilation:
      - polysemy-check-0.9.0.1-EeNz64Zd0kGH4pOWMfGkC9

since the error message itself doesn't give an error location, i need to rely on the line that says Building... above it. this worked best if i cabal test all -j1. a bit tedious, but shouldn't be necessary any more in the future when changes that break things are small and the source of the error is easy to guess.

@fisx fisx force-pushed the remove-unused-deps branch from 40db667 to c0c68f6 Compare April 24, 2023 13:22
@fisx fisx requested a review from elland April 24, 2023 13:24
elland
elland approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@elland elland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love removing dead stuff :D

@fisx fisx merged commit e1384f4 into develop Apr 24, 2023
@fisx fisx deleted the remove-unused-deps branch April 24, 2023 14:18
supersven pushed a commit that referenced this pull request Jul 5, 2023
@fisx @supersven
Remove unused deps (#3242)
cc96478
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@elland elland elland approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fisx @elland @zebot