Skip to content

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Mar 30, 2023

This is not used by CI, and whenever our ghc version string (coming from nixpkgs) changes, we need to manually update this.

Our ghc is coming from nixpkgs, which is pulled in by the dev env, there's no need to have another pin/restriction here.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@flokli flokli requested review from smatting and battermann March 30, 2023 09:24
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Mar 30, 2023
Copy link
Contributor

@supersven supersven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

This is not used by CI, and whenever our ghc version string (coming from
nixpkgs) changes, we need to manually update this.

Our `ghc` is coming from nixpkgs, which is pulled in by the dev env,
there's no need to have another pin/restriction here.
@flokli flokli force-pushed the cabal-project-drop-ghc-version branch from 00b2049 to baeeb9b Compare March 30, 2023 09:55
@flokli
Copy link
Contributor Author

flokli commented Mar 30, 2023

Rebased to now drop with-compiler: ghc-9.2.7 rather than with-compiler: ghc-9.2.4, not waiting for integration tests.

@flokli flokli merged commit c1f21cd into develop Mar 30, 2023
@flokli flokli deleted the cabal-project-drop-ghc-version branch March 30, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants