Skip to content

Revert "Use openssl instead of tls in federator http2 client" #3148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2023
Merged

Revert "Use openssl instead of tls in federator http2 client" #3148

merged 1 commit into from
Mar 13, 2023

Conversation

smatting
Copy link
Contributor

@smatting smatting commented Mar 13, 2023 •
edited
Loading

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Mar 13, 2023
@smatting smatting requested a review from akshaymankar March 13, 2023 12:59
@smatting smatting merged commit 615404b into develop Mar 13, 2023
@smatting smatting deleted the revert-3051-federation-openssl branch March 13, 2023 13:04
@mdimjasevic
Copy link
Contributor

@smatting , will you make a PR to the Frida release branch too? I can do it if you've got something else lined up.

akshaymankar added a commit that referenced this pull request Mar 13, 2023
@akshaymankar
Revert "Revert "Use openssl instead of tls in federator http2 client (#…
9fe09b5 
…3051)" (#3148)"

This reverts commit 615404b.
battermann pushed a commit that referenced this pull request Mar 15, 2023
@smatting @battermann
Revert "Use openssl instead of tls in federator http2 client (#3051)" (…
5ba26cc 
…#3148)

This reverts commit fd78663.
akshaymankar added a commit that referenced this pull request Mar 21, 2023
@akshaymankar
Use openssl instead of tls in federator http2 client (#3154)
2106a61 
* Revert "Revert "Use openssl instead of tls in federator http2 client (#3051)" (#3148)"

This reverts commit 615404b.

* Ensure that when http2 wants n bytes, we give it n bytes

`SSL.read ssl n` doesn't always return `n` bytes, so reading data multiple times
is necessary. Upstream PR has been made to warn future users:
haskell-cryptography/HsOpenSSL#81

* Add changelog

* Remove the IORef read buffer as openssl never returns extra bytes

* Read from openssl in tail recursion
lepsa pushed a commit to lepsa/wire-server that referenced this pull request Nov 28, 2023
@smatting @lepsa
Revert "Use openssl instead of tls in federator http2 client (wireapp…
96dc0f4 
…#3051)" (wireapp#3148)

This reverts commit fd78663.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshaymankar akshaymankar Awaiting requested review from akshaymankar

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smatting @mdimjasevic @zebot