Upgrade rusty-jwt-tools #3112
Merged
Upgrade rusty-jwt-tools #3112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
battermann
force-pushed
the
battermann/update-rusty-jwt-tools
branch
from
1bc9ee4 to
e5e2662
Compare
stefanwire
approved these changes
Mar 1, 2023
| [ test p "success" $ testCreateAccessToken b, | ||
| [ test p "invalid values" $ testCreateAccessTokenInvalidValues b, |
There was a problem hiding this comment.
Is there no happy path test possible anymore?
There was a problem hiding this comment.
Unfortunately not. There is no simple way to create a valid DPoP proof.
This was referenced Mar 6, 2023
2 tasks
lepsa
pushed a commit
to lepsa/wire-server
that referenced
this pull request
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.d