Skip to content

Conversation

smatting
Copy link
Contributor

@smatting smatting commented Nov 7, 2022

This PR re-applies the changes from #2793
which were un-done by #2780

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d

@smatting smatting temporarily deployed to cachix November 7, 2022 12:34 Inactive
@smatting smatting temporarily deployed to cachix November 7, 2022 12:35 Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Nov 7, 2022
Copy link
Member

@akshaymankar akshaymankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps you want to remove this from the previous changelog?

@smatting smatting temporarily deployed to cachix November 7, 2022 13:25 Inactive
@smatting
Copy link
Contributor Author

smatting commented Nov 7, 2022

Perhaps you want to remove this from the previous changelog?

I've reused the previous changelog.d file. Since this is already in master branch a merge back to develop will then conflict with the changes from this PR. I'll resolve it then so that this changelog.d file will not get deleted so it'll end up in the next release. I manually removed the wrong changelog entry from the release notes https://github.com/wireapp/wire-server/releases/tag/v2022-11-03

@smatting smatting requested a review from akshaymankar November 7, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants