Skip to content

[SQSERVICES-1646] Servantify Gundeck #2769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Oct 25, 2022
Merged

[SQSERVICES-1646] Servantify Gundeck #2769

merged 14 commits into from
Oct 25, 2022

Conversation

battermann
Copy link
Contributor

@battermann battermann commented Oct 17, 2022 •
edited
Loading

https://wearezeta.atlassian.net/browse/SQSERVICES-1646

  • post "/push/tokens" (continue addTokenH)
  • delete "/push/tokens/:pid" (continue deleteTokenH)
  • get "/push/tokens" (continue listTokensH)
  • get "/notifications" (continue paginateH)
  • get "/notifications/:id" (continue getByIdH)
  • get "/notifications/last" (continue getLastH)

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@battermann battermann temporarily deployed to cachix October 17, 2022 15:31 Inactive
@battermann battermann temporarily deployed to cachix October 17, 2022 15:31 Inactive
@battermann battermann changed the title post "/push/tokens" SQSERVICES-1646-servantify-gundeck Oct 17, 2022
@battermann battermann changed the title SQSERVICES-1646-servantify-gundeck [SQSERVICES-1646] Servantify Gundeck Oct 17, 2022
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Oct 17, 2022
@battermann battermann force-pushed the SQSERVICES-1646-servantify-gundeck branch from 88aa43f to 371f02a Compare October 18, 2022 14:32
@battermann battermann temporarily deployed to cachix October 18, 2022 14:32 Inactive
@battermann battermann force-pushed the SQSERVICES-1646-servantify-gundeck branch from 371f02a to 12610e6 Compare October 18, 2022 15:15
@battermann battermann temporarily deployed to cachix October 18, 2022 15:16 Inactive
@battermann battermann temporarily deployed to cachix October 19, 2022 13:21 Inactive
@battermann battermann force-pushed the SQSERVICES-1646-servantify-gundeck branch from f392135 to d6eae9a Compare October 20, 2022 07:38
@battermann battermann temporarily deployed to cachix October 20, 2022 07:39 Inactive
@battermann battermann force-pushed the SQSERVICES-1646-servantify-gundeck branch from d6eae9a to d4f9920 Compare October 20, 2022 08:09
@battermann battermann temporarily deployed to cachix October 20, 2022 08:09 Inactive
@battermann battermann force-pushed the SQSERVICES-1646-servantify-gundeck branch from d4f9920 to 86a2491 Compare October 20, 2022 08:49
@battermann battermann temporarily deployed to cachix October 20, 2022 08:49 Inactive
@battermann battermann temporarily deployed to cachix October 20, 2022 09:13 Inactive
@battermann battermann temporarily deployed to cachix October 20, 2022 09:22 Inactive
@battermann battermann temporarily deployed to cachix October 20, 2022 09:34 Inactive
@battermann battermann temporarily deployed to cachix October 20, 2022 14:03 Inactive
@battermann battermann temporarily deployed to cachix October 20, 2022 14:05 Inactive
@battermann battermann force-pushed the SQSERVICES-1646-servantify-gundeck branch from 7efffae to 50f891f Compare October 20, 2022 14:09
@battermann battermann temporarily deployed to cachix October 20, 2022 14:09 Inactive
@battermann battermann marked this pull request as ready for review October 20, 2022 14:09
@battermann battermann requested review from fisx and removed request for fisx October 20, 2022 14:10
@battermann battermann temporarily deployed to cachix October 20, 2022 15:59 Inactive
@battermann battermann requested a review from fisx October 20, 2022 16:08
@battermann battermann force-pushed the SQSERVICES-1646-servantify-gundeck branch from af76d6d to 613bb56 Compare October 21, 2022 07:19
@battermann battermann temporarily deployed to cachix October 21, 2022 07:19 Inactive
@battermann battermann force-pushed the SQSERVICES-1646-servantify-gundeck branch from ad6f324 to 045177e Compare October 24, 2022 08:28
@battermann battermann temporarily deployed to cachix October 24, 2022 08:28 Inactive
@battermann battermann requested a review from fisx October 24, 2022 08:28
@battermann battermann temporarily deployed to cachix October 24, 2022 08:55 Inactive
fisx
fisx reviewed Oct 24, 2022
View reviewed changes
services/gundeck/src/Gundeck/API/Public.hs
Maybe ClientId ->
Maybe (Range 100 10000 Int32) ->
Gundeck (Maybe Public.QueuedNotificationList)
paginate uid mbSince mbClient mbSize = do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a copy of services/gundeck/src/Gundeck/Notification.hs? do you want to remove the latter, than?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this question. The link seems to point to something unrelated.

@fisx
Copy link
Contributor

fisx commented Oct 24, 2022

most of my second batch of comments are nit-picks, and you have a green review, but i still have questions. :) if you want my ok, let's talk, but i trust stephen, you can also just merge.

@battermann battermann temporarily deployed to cachix October 25, 2022 09:02 Inactive
@battermann battermann temporarily deployed to cachix October 25, 2022 09:24 Inactive
@battermann battermann requested a review from fisx October 25, 2022 09:27
@battermann battermann merged commit f51de16 into develop Oct 25, 2022
@battermann battermann deleted the SQSERVICES-1646-servantify-gundeck branch October 25, 2022 10:22
This was referenced Nov 2, 2022
Closed
Merged
akshaymankar added a commit that referenced this pull request Jul 9, 2024
@akshaymankar
gundeck: Reintroduce http metrics for public endpoints
c437918 
Broken during servantification: #2769
akshaymankar added a commit that referenced this pull request Jul 9, 2024
@akshaymankar
gundeck: Reintroduce http metrics for public endpoints
21813c0 
Broken during servantification: #2769
@akshaymankar akshaymankar mentioned this pull request Jul 9, 2024
Open
2 tasks
akshaymankar added a commit that referenced this pull request Jul 9, 2024
@akshaymankar
gundeck: Reintroduce http metrics for public endpoints
2df2ff3 
Broken during servantification: #2769
akshaymankar added a commit that referenced this pull request Jul 9, 2024
@akshaymankar
gundeck: Reintroduce http metrics for public endpoints
ad4f419 
Broken during servantification: #2769
akshaymankar added a commit that referenced this pull request Jul 9, 2024
@akshaymankar
gundeck: Reintroduce http metrics for public endpoints
b4d6ad4 
Broken during servantification: #2769
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fisx fisx Awaiting requested review from fisx

1 more reviewer

@stephen-smith stephen-smith stephen-smith approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@battermann @fisx @stephen-smith @zebot