Update nginz and cannon ACLs to match api-versioned paths #2725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
smatting
force-pushed
the
pcapriotti/update-acl
branch
from
efc637c to
d933637
Compare
smatting
changed the title
smatting
changed the title
smatting
reviewed
Sep 23, 2022
| (path "/assets/v3/**") | ||
| (path "/users") | ||
| (path "/users/**")) | ||
| a (whitelist (regex "/await")) |
There was a problem hiding this comment.
Since cannon only have the /await route there is no need to include other rules
smatting
approved these changes
Sep 23, 2022
pcapriotti
force-pushed
the
pcapriotti/update-acl
branch
from
5504cef to
68c0f8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the ACL files to include api-versioned paths (paths prefixed by
v2/, etc).This PR makes use of the new regex syntax in libzauth that was introduced in #2714
Checklist
changelog.d