Skip to content

Conversation

@battermann
Copy link
Contributor

@battermann battermann commented Sep 19, 2022

https://wearezeta.atlassian.net/browse/SQSERVICES-1643

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@battermann battermann temporarily deployed to cachix September 19, 2022 09:34 Inactive
@battermann battermann temporarily deployed to cachix September 19, 2022 09:34 Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Sep 19, 2022
@battermann battermann force-pushed the SQSERVICES-1643-backend-servantify-brig-account-api-6-password-reset-complete branch from 91b97c6 to 0c75ba9 Compare September 19, 2022 09:35
@battermann battermann temporarily deployed to cachix September 19, 2022 09:35 Inactive
@battermann battermann temporarily deployed to cachix September 19, 2022 09:35 Inactive
@battermann battermann marked this pull request as ready for review September 19, 2022 09:36
@battermann battermann requested a review from fisx September 19, 2022 09:36
@battermann battermann temporarily deployed to cachix September 19, 2022 11:00 Inactive
@battermann battermann temporarily deployed to cachix September 19, 2022 11:00 Inactive
@battermann battermann temporarily deployed to cachix September 19, 2022 11:13 Inactive
@battermann battermann temporarily deployed to cachix September 19, 2022 11:13 Inactive
Comment on lines 198 to 199
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently only used for swagger, I think we should also use this to create the actually error being thrown, you can use errorToWai. There are examples in the Brig.API.Error module.

@battermann battermann force-pushed the SQSERVICES-1643-backend-servantify-brig-account-api-5-password-reset branch from 903a1a0 to 45a8d52 Compare September 20, 2022 08:46
@battermann battermann force-pushed the SQSERVICES-1643-backend-servantify-brig-account-api-6-password-reset-complete branch from 11eff7d to 14b181f Compare September 20, 2022 09:34
@battermann battermann temporarily deployed to cachix September 20, 2022 09:34 Inactive
@battermann battermann temporarily deployed to cachix September 20, 2022 09:34 Inactive
@battermann battermann temporarily deployed to cachix September 20, 2022 09:37 Inactive
@battermann battermann temporarily deployed to cachix September 20, 2022 09:37 Inactive
@battermann battermann force-pushed the SQSERVICES-1643-backend-servantify-brig-account-api-5-password-reset branch from 9ea4c07 to eb1c446 Compare September 22, 2022 07:23
Base automatically changed from SQSERVICES-1643-backend-servantify-brig-account-api-5-password-reset to develop September 22, 2022 14:51
@battermann battermann force-pushed the SQSERVICES-1643-backend-servantify-brig-account-api-6-password-reset-complete branch from c7063d6 to a06b3a2 Compare September 22, 2022 14:57
@battermann battermann temporarily deployed to cachix September 22, 2022 14:57 Inactive
@battermann battermann temporarily deployed to cachix September 22, 2022 14:57 Inactive
@battermann battermann merged commit 9513659 into develop Sep 23, 2022
@battermann battermann deleted the SQSERVICES-1643-backend-servantify-brig-account-api-6-password-reset-complete branch September 23, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants