-
Notifications
You must be signed in to change notification settings - Fork 334
[SQSERVICES-1643] Servantify brig account API 3 - POST /activate
#2701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SQSERVICES-1643] Servantify brig account API 3 - POST /activate
#2701
Conversation
388a9bd to
0425e04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| maybeActivationKeyTargetFromTuple :: (Maybe ActivationKey, Maybe Phone, Maybe Email) -> Parser ActivationTarget | |
| maybeActivationKeyTargetFromTuple = \case | |
| (Just key, _, _) -> pure $ ActivateKey key | |
| (_, _, Just email) -> pure $ ActivateEmail email | |
| (_, Just phone, _) -> pure $ ActivatePhone phone | |
| _ -> fail "key, email or phone must be present" | |
| maybeActivationKeyTargetFromTuple :: (Maybe ActivationKey, Maybe Phone, Maybe Email) -> Parser ActivationTarget | |
| maybeActivationKeyTargetFromTuple = \case | |
| (Just key, _, _) -> pure $ ActivateKey key | |
| (_, _, Just email) -> pure $ ActivateEmail email | |
| (_, Just phone, _) -> pure $ ActivatePhone phone | |
| _ -> fail "key, email or phone must be present" |
I like symmetry! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does was a lie before, right? the json instances didn't know about this field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I noticed that, too.
776df23 to
ea4975a
Compare
0425e04 to
0d6e3e7
Compare
ca38058 to
665bb3c
Compare
700de27 to
c4d0f6f
Compare
https://wearezeta.atlassian.net/browse/SQSERVICES-1643
Checklist
changelog.d