Skip to content

Added hlint pr check makefile cmd. #2690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elland merged 2 commits into from
Sep 15, 2022
Merged

Added hlint pr check makefile cmd. #2690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a743525
Added hlint pr check makefile cmd.
elland Sep 15, 2022
2b5f089
Update tools/hlint.sh
elland Sep 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,15 @@ ghcid:
hlint-check-all:
./tools/hlint.sh -f all -m check

.PHONY: hlint-check-pr
hlint-check-pr:
./tools/hlint.sh -f pr -m check

.PHONY: hlint-inplace-pr
hlint-inplace-pr:
./tools/hlint.sh -f pr -m inplace


.PHONY: hlint-inplace-all
hlint-inplace-all:
./tools/hlint.sh -f all -m inplace
Expand Down
3 changes: 3 additions & 0 deletions tools/hlint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ while getopts ':f:m:' opt
if [ "$f" = "all" ]; then
files=$(find libs/ services/ -not -path "*/test/*" -name "*.hs")
echo "WARNING: not linting tests."
elif [ "$f" = "pr" ]; then
files=$(git diff --name-only origin/develop... | grep \.hs\$)
echo "WARNING: linting test files with changes. This may lead to some hard to fix warnings/errors, it is safe to ignore those!"
elif [ "$f" = "changeset" ]; then
files=$(git diff --name-only HEAD | grep \.hs\$)
echo "WARNING: linting test files with changes. This may lead to some hard to fix warnings/errors, it is safe to ignore those!"
Expand Down