Skip to content

Conversation

fisx
Copy link
Contributor

@fisx fisx commented Aug 29, 2022

(for compilation speed)

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • If this PR changes development workflow or dependencies, they have been A) automated and B) documented under docs/developer/. All efforts have been taken to minimize development setup breakage or slowdown for co-workers.
  • If HTTP endpoint paths have been added or renamed, check docs/developer/adding-api-endpoints and follow the steps there.
  • If configuration options have been added or removed, check docs/developer/adding-config-options and follow the steps there.
  • If a cassandra schema migration has been added, I ran make git-add-cassandra-schema to update the cassandra schema documentation.
  • I swear that if I have changed internal end-points, I do not implicitly rely on deployment ordering (brig needing to be deployed before galley), i.e. I have not introduced a new internal endpoint in brig and already make use of if in galley, as I'm aware old deployed galleys would throw 500s until all new version have been rolled out and I do not want a few minutes of downtime. Instead, I have thought how to merge brig an galley codebases.
  • I updated changelog.d subsections with one or more entries with the following bits of information (details):
    • If a cassandra schema migration is backwards incompatible (see also these docs), measures to be taken by on-premise instance operators are explained.
    • If a data migration (not schema migration) introduced: measures to be taken by on-premise instance operators.

@fisx fisx requested a review from akshaymankar August 29, 2022 08:34
@fisx fisx temporarily deployed to cachix August 29, 2022 08:35 Inactive
@fisx fisx temporarily deployed to cachix August 29, 2022 08:35 Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Aug 29, 2022
@fisx fisx temporarily deployed to cachix August 29, 2022 08:36 Inactive
@fisx fisx temporarily deployed to cachix August 29, 2022 08:36 Inactive
@fisx fisx temporarily deployed to cachix August 29, 2022 09:03 Inactive
@fisx fisx temporarily deployed to cachix August 29, 2022 09:03 Inactive
@fisx fisx merged commit 9f46f44 into develop Aug 29, 2022
@fisx fisx deleted the move-common-arbitrary-instances branch August 29, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants