Skip to content

Make mlsPrivateKeys value optional #2642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2022
Merged

Make mlsPrivateKeys value optional #2642

merged 1 commit into from
Aug 22, 2022

Conversation

pcapriotti
Copy link
Contributor

This is a followup to #2602, fixing an issue with the helm templates. This PR makes it possible to omit the mlsPrivateKeys value.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.

@pcapriotti pcapriotti temporarily deployed to cachix August 22, 2022 11:13 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix August 22, 2022 11:13 Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Aug 22, 2022
@pcapriotti pcapriotti marked this pull request as ready for review August 22, 2022 11:31
@pcapriotti pcapriotti merged commit e8dec26 into develop Aug 22, 2022
@pcapriotti pcapriotti deleted the pcapriotti/mls-private-keys-helm-fix branch August 22, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smatting smatting smatting approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcapriotti @smatting @zebot