Skip to content

mls-test-cli - use Cargo.lock #2634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 19, 2022
Merged

mls-test-cli - use Cargo.lock #2634

merged 2 commits into from
Aug 19, 2022

Conversation

smatting
Copy link
Contributor

This PR builds mls-test-cli with cargo build instead of cargo install, because cargo install without the --locked file ignores Cargo.lock (which we don't want).

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):

@smatting smatting added the not-ok-to-test Not approved for running tests in CI, this label is ignored if ok-to-test also exists on a PR label Aug 19, 2022
@smatting smatting temporarily deployed to cachix August 19, 2022 09:49 Inactive
@smatting smatting temporarily deployed to cachix August 19, 2022 09:49 Inactive
@smatting smatting merged commit 86895b8 into develop Aug 19, 2022
@smatting smatting deleted the FS-823-mls-test-cli-lock-file branch August 19, 2022 09:50
@zebot zebot mentioned this pull request Sep 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcapriotti pcapriotti pcapriotti approved these changes

@stefanwire stefanwire stefanwire approved these changes

Assignees
No one assigned
Labels
not-ok-to-test Not approved for running tests in CI, this label is ignored if ok-to-test also exists on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smatting @pcapriotti @stefanwire