Skip to content

Conversation

smatting
Copy link
Contributor

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • If this PR changes development workflow or dependencies, they have been A) automated and B) documented under docs/developer/. All efforts have been taken to minimize development setup breakage or slowdown for co-workers.
  • If HTTP endpoint paths have been added or renamed, or feature configs have changed, the endpoint / config-flag checklist (see Wire-employee only backend wiki page) has been followed.
  • If a cassandra schema migration has been added, I ran make git-add-cassandra-schema to update the cassandra schema documentation.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.
    • If new config options introduced: added usage description under docs/reference/config-options.md
    • If new config options introduced: recommended measures to be taken by on-premise instance operators.
    • If a cassandra schema migration is backwards incompatible (see also these docs), measures to be taken by on-premise instance operators are explained.
    • If a data migration (not schema migration) introduced: measures to be taken by on-premise instance operators.
    • If public end-points have been changed or added: does nginz need un upgrade?
    • If internal end-points have been added or changed: which services have to be deployed in a specific order?

@smatting smatting temporarily deployed to cachix August 11, 2022 14:05 Inactive
@smatting smatting temporarily deployed to cachix August 11, 2022 14:05 Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Aug 11, 2022
cd /tmp && \
git clone https://github.com/wireapp/cryptobox-c.git && \
cd cryptobox-c && \
export SODIUM_USE_PKG_CONFIG=1 && \
cargo build --release

# compile mls-test-cli tool
# note: to make use of rustup's toolchain you need to prefix commands by . "$HOME/.cargo/env"
RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
Copy link
Contributor Author

@smatting smatting Aug 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its' not ideal that we rely on a source like rustup.rs. Can we find a ubuntu-official way to get a more up-to-date version

@stefanwire stefanwire temporarily deployed to cachix August 12, 2022 15:10 Inactive
@stefanwire stefanwire temporarily deployed to cachix August 12, 2022 15:10 Inactive
@stefanwire stefanwire force-pushed the smatting/mls-test-cli-rustup branch from 49f3145 to 72e3ddc Compare August 12, 2022 15:13
@stefanwire stefanwire temporarily deployed to cachix August 12, 2022 15:13 Inactive
@stefanwire stefanwire temporarily deployed to cachix August 12, 2022 15:13 Inactive
@pcapriotti pcapriotti marked this pull request as ready for review August 15, 2022 09:45
@pcapriotti pcapriotti changed the title Use rustup to build mls-test-cli Use rust image to build mls-test-cli Aug 15, 2022
@pcapriotti pcapriotti merged commit bfaa99a into develop Aug 15, 2022
@pcapriotti pcapriotti deleted the smatting/mls-test-cli-rustup branch August 15, 2022 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants