Skip to content

Tweak nix env, cabal-fmt #2609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 11, 2022
Merged

Tweak nix env, cabal-fmt #2609

merged 5 commits into from
Aug 11, 2022

Conversation

fisx
Copy link
Contributor

@fisx fisx commented Aug 11, 2022 •
edited
Loading

See commits for details.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.

@fisx fisx requested a review from smatting August 11, 2022 07:10
@fisx fisx temporarily deployed to cachix August 11, 2022 07:10 Inactive
@fisx fisx temporarily deployed to cachix August 11, 2022 07:10 Inactive
@fisx
Copy link
Contributor Author

fisx commented Aug 11, 2022

Thanks @smatting for the nix fix!

Would it be better to have a changelog entry for this? I am leaning towards "no".

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Aug 11, 2022
@fisx fisx marked this pull request as ready for review August 11, 2022 07:14
smatting
smatting approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@smatting smatting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I always add a changelog entry because I assume otherwise the release manager has to come up with one. But if that's not the case I think it's fine to leave it out.

@fisx fisx temporarily deployed to cachix August 11, 2022 11:42 Inactive
@fisx fisx temporarily deployed to cachix August 11, 2022 11:43 Inactive
@fisx fisx merged commit 18d469e into develop Aug 11, 2022
@fisx fisx deleted the tweak-stuff branch August 11, 2022 12:37
@zebot zebot mentioned this pull request Aug 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smatting smatting smatting approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fisx @smatting @zebot