Skip to content

Conversation

pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Aug 8, 2022

This PR reorganises the MLS Message type to support correct signature verification. The new Message type is now composed of a TBS and a separate signature (together with unsigned extra fields). In the case of a ciphertext message, the signature and extra fields are empty.

This supersedes parts of #2567, but it does not contain any code for supporting external proposals in Galley.

Tracked by https://wearezeta.atlassian.net/browse/FS-435.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@pcapriotti pcapriotti temporarily deployed to cachix August 8, 2022 14:37 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix August 8, 2022 14:37 Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Aug 8, 2022
@pcapriotti pcapriotti temporarily deployed to cachix August 8, 2022 14:39 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix August 8, 2022 14:39 Inactive
@smatting smatting marked this pull request as ready for review August 8, 2022 16:31
@smatting smatting self-requested a review August 8, 2022 16:31
@smatting smatting merged commit 35ca3fb into develop Aug 8, 2022
@smatting smatting deleted the pcapriotti/message-tbs branch August 8, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants