Fix message signature verification #2599
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reorganises the MLS
Message
type to support correct signature verification. The newMessage
type is now composed of a TBS and a separate signature (together with unsigned extra fields). In the case of a ciphertext message, the signature and extra fields are empty.This supersedes parts of #2567, but it does not contain any code for supporting external proposals in Galley.
Tracked by https://wearezeta.atlassian.net/browse/FS-435.
Checklist
changelog.d
.