Skip to content

Drop hpack #2596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 9, 2022
Merged

Drop hpack #2596

merged 3 commits into from
Aug 9, 2022

Conversation

fisx
Copy link
Contributor

@fisx fisx commented Aug 5, 2022

We've discussed this in the past, with the following alternatives being tossed around:

  • keep both package.yaml and cabal files
  • keep only package.yaml files
  • keep only cabal files

I am not completely certain, but I think the last had the least resistance from everybody, so I'll raise this in the standup on Monday, and if I get at least one approval and no objections, I'll merge this.

@fisx fisx temporarily deployed to cachix August 5, 2022 10:27 Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Aug 5, 2022
@smatting smatting mentioned this pull request Aug 9, 2022
Merged
4 tasks
@smatting smatting self-requested a review August 9, 2022 13:54
smatting
smatting approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@smatting smatting left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I'd like to propose cabal-fmt as a replacement: #2601

@fisx fisx merged commit 437993d into develop Aug 9, 2022
@fisx fisx deleted the drop-hpack branch August 9, 2022 14:05
@zebot zebot mentioned this pull request Aug 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smatting smatting smatting approved these changes

+1 more reviewer

@elland elland elland approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fisx @elland @smatting @zebot