Sqservices 1533 be give saml id ps human readable names in tm #2565
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/SQSERVICES-1533
handle
is an optional query parameter on the POST and PUT requests. Can't easily add it to the body because the content-type is XML. Refactoring this will be a breaking change for the clients.When a handle is not given, we will generate one like "IdP 1..n" and take the first one that is not used already.
If an IdP already exists, the handle that is returned is generated from the uuid of the IdP, taking the first 6 characters, e.g.
Since IdP handles are only alias, the uniqueness requirements for the handle can be a bit softer. Also, team admins can simply change the handles in case of a clash.
There was a discussion in the BE channel about a potential data migration. But the current implementation doesn’t need one, if it is acceptable from the user’s point of view to have the handles generated from the IdP Id as described above. There is also no need to update the database on GET requests, as discussed elsewhere.
Checklist
make git-add-cassandra-schema
to update the cassandra schema documentation.changelog.d
.