Remove non binding teams #2514
Merged
Remove non binding teams #2514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
battermann
force-pushed
the
battermann/remove-non-binding-team
branch
from
cb1ca41 to
ae36ed9
Compare
zebot
added
the
ok-to-test
fisx
reviewed
Aug 9, 2022
fisx
reviewed
Aug 9, 2022
fisx
approved these changes
Aug 9, 2022
|
One more thing: There are now a lot of names containing "binding", which doesn't make sense any more now. I wonder if there should be another PR cleaning those up as well? |
I think we should do this in another PR. |
fisx
reviewed
Aug 9, 2022
| @@ -586,7 +586,7 @@ testRegularUserLegalHoldLogin brig = do | |||
| uid <- userId <$> randomUser brig | |||
| -- fail if user is not a team user | |||
| legalHoldLogin brig (LegalHoldLogin uid (Just defPassword) Nothing) PersistentCookie !!! do | |||
| const 403 === statusCode | |||
| const 404 === statusCode | |||
There was a problem hiding this comment.
@dkovacevic do you check the specifics of 4xx when logging in LH devices? we're changing the status code for an error condition from 403 to 404 here, any objections?
Co-authored-by: fisx <[email protected]>
Co-authored-by: fisx <[email protected]>
battermann
force-pushed
the
battermann/remove-non-binding-team
branch
from
cc50dbf to
9fb8e8d
Compare
fisx
added a commit
that referenced
this pull request
Aug 10, 2022
This reverts commit b1c39db. (part 1)
fisx
added a commit
that referenced
this pull request
Aug 10, 2022
This reverts parts of commit b1c39db. Changes to integration tests remain intact (we don't test non-binding teams any more).
fisx
added a commit
that referenced
this pull request
Aug 10, 2022
Co-authored-by: Leif Battermann <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/SQSERVICES-1619
Remove deprecated non-binding teams code.
Checklist
changelog.d.