Skip to content

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Jun 14, 2022

Use the same set of labels for the nginz service that we add to other
services.

The ServiceMonitor resource wants app=nginz, which right now is missing

  • so the ServiceMonitor doesn't select anything currently.

Follow-up of #2476.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • If this PR changes development workflow or dependencies, they have been A) automated and B) documented under docs/developer/. All efforts have been taken to minimize development setup breakage or slowdown for co-workers.
  • If HTTP endpoint paths have been added or renamed, or feature configs have changed, the endpoint / config-flag checklist (see Wire-employee only backend wiki page) has been followed.
  • If a cassandra schema migration has been added, I ran make git-add-cassandra-schema to update the cassandra schema documentation.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.
    • If new config options introduced: added usage description under docs/reference/config-options.md
    • If new config options introduced: recommended measures to be taken by on-premise instance operators.
    • If a cassandra schema migration is backwards incompatible (see also these docs), measures to be taken by on-premise instance operators are explained.
    • If a data migration (not schema migration) introduced: measures to be taken by on-premise instance operators.
    • If public end-points have been changed or added: does nginz need un upgrade?
    • If internal end-points have been added or changed: which services have to be deployed in a specific order?

Use the same set of labels for the nginz service that we add to other
services.

The ServiceMonitor resource wants app=nginz, which right now is missing
- so the ServiceMonitor doesn't select anything currently.

Follow-up of #2476.
@flokli flokli temporarily deployed to cachix June 14, 2022 12:43 Inactive
@flokli flokli merged commit 34090d6 into develop Jun 14, 2022
@flokli flokli deleted the nginz-missing-labels branch June 14, 2022 13:04
@flokli
Copy link
Contributor Author

flokli commented Jun 14, 2022

This should probably end in #2482 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants