Skip to content

Make all feature configs overridable #2479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 14, 2022
Merged

Make all feature configs overridable #2479

merged 2 commits into from
Jun 14, 2022

Conversation

battermann
Copy link
Contributor

@battermann battermann commented Jun 14, 2022 •
edited
Loading

All feature configs like guest links e.g. can now be overridden in the helm configuration, so that they can be disabled/enabled and configured server wide.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@battermann battermann temporarily deployed to cachix June 14, 2022 10:35 Inactive
@battermann battermann changed the title update galley configmap to make feature overridable, and add optional… Make all feature configs overridable Jun 14, 2022
@battermann battermann temporarily deployed to cachix June 14, 2022 10:41 Inactive
@battermann battermann requested a review from smatting June 14, 2022 10:42
smatting
smatting approved these changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@smatting smatting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked again

  • that configmap can be read by galley
  • that the default in values in the values.yaml correspond to the hardcoded fallback default values

@battermann battermann merged commit 9d10aa4 into develop Jun 14, 2022
@battermann battermann deleted the battermann/make-all-feature-configs-overridable branch June 14, 2022 12:04
@zebot zebot mentioned this pull request Jun 14, 2022
Merged
battermann added a commit that referenced this pull request Jun 14, 2022
@battermann
Make all feature configs overridable (#2479)
0bb42cd
fisx pushed a commit that referenced this pull request Jun 15, 2022
@battermann @zebot
Merge master to develop release 2022 06 14 2 (#2488)
0d89b7b 
* chore: [charts] Update webapp version (#2475)

Co-authored-by: Zebot <[email protected]>

* chore: [charts] Update team-settings version (#2477)

Co-authored-by: Zebot <[email protected]>

* added guest link feature config docs (#2480)

* Make all feature configs overridable (#2479)

* Add changelog for Release 2022-06-14

Co-authored-by: zebot <[email protected]>
Co-authored-by: Zebot <[email protected]>
rohan-wire pushed a commit that referenced this pull request Jun 28, 2022
@battermann @rohan-wire
Make all feature configs overridable (#2479)
23e8666
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smatting smatting smatting approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@battermann @smatting