Skip to content

charts/{cannon,nginz}: Allow configuring arbitrary hosts for CORS allowlisting #2438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2022

Conversation

akshaymankar
Copy link
Member

Some internal test environments like staging, must allow requests from arbitrary domains which different teams use. It should also allow requests from localhost:<some-port>. This PR expands the purpose of nginx_conf.randomport_allowlisted_origins to allow any arbitrary host name.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@akshaymankar akshaymankar temporarily deployed to cachix May 30, 2022 15:38 Inactive
@akshaymankar akshaymankar requested a review from jschaul May 30, 2022 15:38
@jschaul jschaul merged commit 6c9a2b4 into develop May 31, 2022
@jschaul jschaul deleted the akshaymankar/nginz-randomport branch May 31, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants