Skip to content

charts/brig: Support running brig with GeoIP database #2406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 18, 2022

Conversation

akshaymankar
Copy link
Member

@akshaymankar akshaymankar commented May 18, 2022

This optionally allows configuring GeoIP to make IP->latitude/longitude lookups. When this is enabled, brig uses this during client registration to save from where a certain client was registered.

Related PR: https://github.com/zinfra/cailleach/pull/1087

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@akshaymankar akshaymankar temporarily deployed to cachix May 18, 2022 09:32 Inactive
Set it to 0 in the init container to only run it once, this also helps get rid
of shell code to update it once.
@akshaymankar akshaymankar temporarily deployed to cachix May 18, 2022 10:00 Inactive
@akshaymankar akshaymankar temporarily deployed to cachix May 18, 2022 10:12 Inactive
@jschaul jschaul temporarily deployed to cachix May 18, 2022 13:17 Inactive
@jschaul jschaul temporarily deployed to cachix May 18, 2022 13:31 Inactive
Also encode geoip secrets as base64
@akshaymankar akshaymankar temporarily deployed to cachix May 18, 2022 16:00 Inactive
@jschaul jschaul temporarily deployed to cachix May 18, 2022 17:31 Inactive
@jschaul jschaul marked this pull request as ready for review May 18, 2022 17:57
@jschaul jschaul merged commit d550393 into develop May 18, 2022
@jschaul jschaul deleted the akshaymankar/brig-geoip branch May 18, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants