Skip to content

SQSERVICES-1560-more-canonical-handling-of-hard-wired-defaults-type-class-have-defaults-for-all-features #2404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

battermann
Copy link
Contributor

@battermann battermann commented May 17, 2022

https://wearezeta.atlassian.net/browse/SQSERVICES-1560

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@battermann battermann temporarily deployed to cachix May 17, 2022 15:24 Inactive
@battermann battermann changed the title type class for team feature defaults SQSERVICES-1560-more-canonical-handling-of-hard-wired-defaults-type-class-have-defaults-for-all-features May 17, 2022
Copy link
Contributor

@fisx fisx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like it so far!

i think the benefit from this will become more obvious if you change the parser for galley.yaml to accept each feature, but make all of them optional (but that's a separate PR).

class TeamFeatureDefaults (a :: TeamFeatureName) where
defTeamFeatureStatus :: TeamFeatureStatus 'WithLockStatus a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class TeamFeatureDefaults (a :: TeamFeatureName) where
defTeamFeatureStatus :: TeamFeatureStatus 'WithLockStatus a
class DefTeamFeatureStatus (a :: TeamFeatureName) where
defTeamFeatureStatus :: TeamFeatureStatus 'WithLockStatus a

@battermann battermann temporarily deployed to cachix May 18, 2022 06:47 Inactive
@battermann battermann marked this pull request as ready for review May 18, 2022 06:47
@battermann battermann force-pushed the SQSERVICES-1560-more-canonical-handling-of-hard-wired-defaults-type-class-have-defaults-for-all-features branch from c9b2ad9 to 02d074e Compare May 18, 2022 08:50
@battermann battermann temporarily deployed to cachix May 18, 2022 08:51 Inactive
@battermann battermann force-pushed the SQSERVICES-1559-make-all-feature-configs-typed branch from 024b010 to f4f4420 Compare May 18, 2022 13:09
Base automatically changed from SQSERVICES-1559-make-all-feature-configs-typed to develop May 19, 2022 11:45
@battermann battermann force-pushed the SQSERVICES-1560-more-canonical-handling-of-hard-wired-defaults-type-class-have-defaults-for-all-features branch from 02d074e to fcc0e50 Compare May 19, 2022 13:33
@battermann battermann temporarily deployed to cachix May 19, 2022 13:33 Inactive
@battermann battermann merged commit 152ea15 into develop May 23, 2022
@battermann battermann deleted the SQSERVICES-1560-more-canonical-handling-of-hard-wired-defaults-type-class-have-defaults-for-all-features branch May 23, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants