-
Notifications
You must be signed in to change notification settings - Fork 333
show package name for which tests run #2392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hack/bin/cabal-run-all-tests.sh
Outdated
xargs -n 1 "$DIR/cabal-run-tests.sh" | ||
xargs -n 1 echo) | ||
|
||
for p in $packages; do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the workaround[1] isn't worth it, but this will cause problems if there's ever an IFS character (e.g. SPC) in a package name.
[1] Have xargs invoke a /bin/sh subshell and use $1 there instead of $p.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think using xargs makes it not possible to stop the execution on first test failure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can definately stop a GNU xargs run:
If any invocation of the command exits with a status of 255, xargs will stop immediately without reading any further input.
and that's standard behavior, too:
This sequence shall be repeated until one of the following occurs: [...] An invocation of a constructed command line returns an exit status of 255.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get the discussion; haskell package names never contain spaces, so this is a silly objection. But if that's what it takes to get a positive review on this PR that has been hanging for two weeks; then; sure, see 5e3333e.
…eadable upon request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, it was not my intent to hold things up or require any changes.
This change leads to the following new behaviour:
doesn't warrant a changelog I think.