Skip to content

Conversation

akshaymankar
Copy link
Member

@akshaymankar akshaymankar commented May 12, 2022

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.
    • If new config options introduced: added usage description under docs/reference/config-options.md
    • If new config options introduced: recommended measures to be taken by on-premise instance operators.
      This is not required as the change is backwards compatibile.

@akshaymankar akshaymankar temporarily deployed to cachix May 12, 2022 10:36 Inactive
@akshaymankar akshaymankar temporarily deployed to cachix May 12, 2022 14:06 Inactive
@akshaymankar akshaymankar temporarily deployed to cachix May 12, 2022 14:57 Inactive
@akshaymankar akshaymankar temporarily deployed to cachix May 12, 2022 15:31 Inactive
Co-authored-by: jschaul <[email protected]>
@akshaymankar akshaymankar temporarily deployed to cachix May 16, 2022 08:34 Inactive
@akshaymankar akshaymankar temporarily deployed to cachix May 16, 2022 08:50 Inactive
This avoids the race when asserting on calls after detecting a tick
@akshaymankar akshaymankar temporarily deployed to cachix May 16, 2022 08:55 Inactive
@akshaymankar akshaymankar temporarily deployed to cachix May 16, 2022 11:46 Inactive
@akshaymankar akshaymankar temporarily deployed to cachix May 16, 2022 12:03 Inactive
@akshaymankar akshaymankar temporarily deployed to cachix May 16, 2022 13:19 Inactive
@akshaymankar akshaymankar temporarily deployed to cachix May 16, 2022 13:59 Inactive
@akshaymankar akshaymankar marked this pull request as ready for review May 16, 2022 14:00
@akshaymankar akshaymankar force-pushed the akshaymankar/turn-discovery-impl branch from d6cfb13 to 1cb09fb Compare May 16, 2022 14:03
@akshaymankar akshaymankar temporarily deployed to cachix May 16, 2022 14:03 Inactive
@akshaymankar akshaymankar temporarily deployed to cachix May 16, 2022 14:47 Inactive
@akshaymankar akshaymankar temporarily deployed to cachix May 16, 2022 14:52 Inactive
@jschaul jschaul temporarily deployed to cachix May 16, 2022 15:56 Inactive
@akshaymankar akshaymankar temporarily deployed to cachix May 17, 2022 08:14 Inactive
@akshaymankar akshaymankar merged commit a1d325a into develop May 17, 2022
@akshaymankar akshaymankar deleted the akshaymankar/turn-discovery-impl branch May 17, 2022 09:27
@jschaul
Copy link
Member

jschaul commented May 17, 2022

🎆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants