Skip to content

Brig: Prepare for TURN Discovery using SRV records #2376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 12, 2022
Merged

Brig: Prepare for TURN Discovery using SRV records #2376

merged 4 commits into from
May 12, 2022

Conversation

akshaymankar
Copy link
Member

@akshaymankar akshaymankar commented May 10, 2022 •
edited
Loading

Two changes:

  1. Start TURN discovery only when the app starts

Instead of starting it when the Env is created. This aligns the service
discovery of TURN with that of SFT. In next commits, SRV based discovery for
TURN will be implemented.

  1. Refactor SFT SRV Record discovery to make it more generic and reusable

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@akshaymankar akshaymankar temporarily deployed to cachix May 10, 2022 08:25 Inactive
@akshaymankar
Brig: Start turn discovery when the App start
b72c358 
Instead of starting it when the `Env` is created. This aligns the service
discovery of TURN with that of SFT. In next commits, SRV based discovery for
TURN will be implemented.
@akshaymankar akshaymankar force-pushed the akshaymankar/turn-discovery branch from cd4b038 to b72c358 Compare May 10, 2022 08:40
@akshaymankar akshaymankar temporarily deployed to cachix May 10, 2022 08:40 Inactive
@akshaymankar akshaymankar temporarily deployed to cachix May 10, 2022 13:25 Inactive
@akshaymankar akshaymankar changed the title Brig: Implement SRV recod based discovery of TURN servers Brig: Start TURN discovery only when the app starts May 11, 2022
@akshaymankar akshaymankar changed the title Brig: Start TURN discovery only when the app starts Brig: Prepare for TURN Discovery using SRV records May 11, 2022
@akshaymankar
Brig: Refactor SFT Discovery tests
bf14311 
* Simplify sftDiscoveryLoop tests and make them srvDiscoveryLoop tests
* Introduce a Delay Effect to deal with threadDelay and mock it to get rid of
wait loop in tests
@akshaymankar akshaymankar temporarily deployed to cachix May 11, 2022 14:10 Inactive
@akshaymankar akshaymankar temporarily deployed to cachix May 11, 2022 14:23 Inactive
@akshaymankar akshaymankar marked this pull request as ready for review May 11, 2022 14:26
@akshaymankar akshaymankar merged commit 7f1ffb7 into develop May 12, 2022
@akshaymankar akshaymankar deleted the akshaymankar/turn-discovery branch May 12, 2022 07:26
@zebot zebot mentioned this pull request May 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschaul jschaul jschaul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akshaymankar @jschaul