-
Notifications
You must be signed in to change notification settings - Fork 333
Adapt wire-server charts so they can be used to run wire cloud #2347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt wire-server charts so they can be used to run wire cloud #2347
Conversation
This commit also removes the unnecessarily mounted secret. All the information in the secret gets exposed as environment variable anyway.
This commit also removes the unnecessarily mounted secret. All the information in the secret gets exposed as environment variable anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This iteration of helm chart changes is working, LGTM.
A changelog entry would be nice to add, though.
CI seems to be failing though, still. |
c8ed846
to
edfed93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the detailed description!
@@ -0,0 +1,2 @@ | |||
charts/{brig,cargohol,galley,gundeck}: Allow not configuring AWS credentials and allow using a special service account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/cargohol/cargohold
small typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed here: #2399
charts/{brig,cargohol,galley,gundeck}: Allow not configuring AWS credentials and allow using a special service account.
This way, when operating wire in AWS cloud either instance profiles or IAM role attached to a service account can be used to communicate with AWS.
Allow new configurations in the brig chart:
config.emailSMS.user.invitationUrl
config.emailSMS.team.tInvitationUrl
config.emailSMS.team.tActivationUrl
config.emailSMS.team.tCreatorWelcomeUrl
config.emailSMS.team.tMemberWelcomeUrl
config.setProviderSearchFilter
config.setWhitelist
config.setFeatureFlags
config.setCustomerExtensions
If any values in config.emailSMS.team are specified, all must be specified.
Allow new configurations in the gundeck chart:
config.perNativePushConcurrency
config.maxConcurrentNativePushes.soft
config.maxConcurrentNativePushes.hard
Other changes:
maxTeamSize
changed from 500 to 10000. (larger teams have been supported by wire-server code for a while; but the default value had not been increased yet)Checklist
make git-add-cassandra-schema
to update the cassandra schema documentation.changelog.d
.