Prevent duplicated rendering of FEATURE_ENABLE_PAYMENT

[supersven]

If the FEATURE_ENABLE_PAYMENT feature flag is set by envVars, do not render it again. Otherwise, we might end up in confusing cases like: The flag was set to true, but it's additionally rendered with a default to false.

I gave the envVars entry priority because it's used many times in cailleach and my gut feeling tells me that it would be confusing to override an explicitly set flag with an opposite value.

Example from k8s:

kubectl get pod -n wire team-settings-598ddf7956-r6jfn -o yaml

...
spec:
  containers:
  - env:
    - name: NODE_PORT
      value: "8080"
    - name: APP_BASE
      value: https://teams.secusmart-column-1a.wire.link/
    - name: BACKEND_REST
      value: https://nginz-https.secusmart-column-1a.wire.link
    - name: BACKEND_WS
      value: wss://nginz-ssl.secusmart-column-1a.wire.link
    - name: FEATURE_ENABLE_PAYMENT
      value: "false"
    - name: FEATURE_ENABLE_PAYMENT
      value: "false"
...

Checklist

• The PR Title explains the impact of the change.
• The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
• changelog.d contains the following bits of information (details):
  • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

[fisx]

This makes sense to me. Of course it also raises the question if we really need envVars in the first place. Do I understand correctly that this is posix/shell env, and what's under .Values.config is from values.yaml? I would strongly suggest we drop env variable handling, or at least deprecate it. But I may be missing an important use case.

[supersven]

NB: I'm still testing this. Happy about your approvals. But, please don't merge, yet... ☝️

[supersven]

This makes sense to me. Of course it also raises the question if we really need envVars in the first place. Do I understand correctly that this is posix/shell env, and what's under .Values.config is from values.yaml? I would strongly suggest we drop env variable handling, or at least deprecate it. But I may be missing an important use case.

Hey @fisx ,

In my PIT branch of reality envVars shows up like this: https://github.com/zinfra/cailleach/blob/master/environments/secusmart-column-1a/helm_vars/wire-server/values.yaml.gotmpl#L207

It's both values.yaml stuff. I think envVars is called as it is, because it relates to the environment variables for the K8s pod of team-settings. So, it's env variables inside the deployed cluster (not on your local machine).

[supersven]

Tested successfully.