Skip to content

docs: add latex to docs and publish pdf if exists #2321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 26, 2022
Merged

docs: add latex to docs and publish pdf if exists #2321

merged 2 commits into from
Apr 26, 2022

Conversation

smatting
Copy link
Contributor

@smatting smatting commented Apr 26, 2022 •
edited
Loading

This PR

  • adds latex back to the build env of the docs.
  • adds publishing of the pdf to docs.wire.com/main.pdf when running "make push"

Context: #2258 (comment)

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):

@smatting smatting temporarily deployed to cachix April 26, 2022 13:44 Inactive
@smatting smatting mentioned this pull request Apr 26, 2022
Merged
4 tasks
arthurwolf
arthurwolf approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@arthurwolf arthurwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything good.

@smatting smatting merged commit 5f667d7 into develop Apr 26, 2022
@smatting smatting deleted the smatting/wire-docs-pdf branch April 26, 2022 15:48
smatting added a commit that referenced this pull request Apr 27, 2022
@smatting
Fixup for #2321 (#2323)
932bfa0
supersven pushed a commit that referenced this pull request Apr 29, 2022
@smatting @supersven
docs: add latex to docs and publish pdf if exists (#2321)
9a4bbe6
@zebot zebot mentioned this pull request May 4, 2022
Merged
@zebot zebot mentioned this pull request May 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohan-wire rohan-wire Awaiting requested review from rohan-wire

1 more reviewer

@arthurwolf arthurwolf arthurwolf approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smatting @arthurwolf